This repository was archived by the owner on Aug 3, 2024. It is now read-only.
Allow more characters in anchor following module reference #1220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbiehl
approved these changes
Dec 8, 2020
alexbiehl-gc
pushed a commit
to alexbiehl/haddock
that referenced
this pull request
Dec 8, 2020
garetxe
pushed a commit
to garetxe/haddock
that referenced
this pull request
Jan 15, 2021
There were some conflicts with haskell#1220, fixed those.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the only allowed characters in a
"module#anchor" anchor are alphanums plus[.#\\]. In particular it rejects hyphens-, which are pretty common in anchors.This PR refines the parsing of anchors in modules to allow more characters, and also reject spaces (because they're technically not allowed by HTML).